Update to latest hashbrown, fix determinism of build #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 1 1
Lines 962 962
=======================================
Hits 958 958
Misses 4 4 Continue to review full report at Codecov.
|
|
Hi @gnunicorn, thanks for the PR! I'm happy to land this change, out of an abundance of caution though, I think I'll release it as a new minor version (i.e. |
Closed
|
When the major version is 0, cargo treats the minor version as the major version, so that should be a very safe approach. |
|
Will go ahead and merge this and then release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates hashbrown to the latest release (
0.8.0).In the 0.6 series hashbrown's default feature set activated the compile-time-rng-feature in ahash, the internally used hasher – which lead to non-deterministic builds even on the same system. In the latest series this feature is not enabled by hashbrown by default anymore. Updating to that series fixes that problem.
As far as I can tell, this could be released as a non-breaking patch release.